-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move masp validation from SDK into shielded_token crate #3419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment but LGTM!
The |
So |
so the problem was indeed in |
89eaa9f
to
2f3abec
Compare
I rm'd the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3419 +/- ##
==========================================
- Coverage 53.92% 53.91% -0.01%
==========================================
Files 317 318 +1
Lines 107575 107569 -6
==========================================
- Hits 58011 58001 -10
- Misses 49564 49568 +4 ☔ View full report in Codecov by Sentry. |
2f3abec
to
d6212b9
Compare
* tomas/move-verify-shielded: changelog: add #3419 shielded_token: feature guard validation to avoid compilation into wasm move masp validation from SDK into shielded_token crate
* origin/tomas/move-verify-shielded: changelog: add #3419 shielded_token: feature guard validation to avoid compilation into wasm move masp validation from SDK into shielded_token crate
Describe your changes
closes #3101
Indicate on which release or other PRs this topic is based on
0.39.0
Checklist before merging to
draft